Handle file system permissions #11965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msujew
added
filesystem
vince-fugnitto
approved these changes
Dec 7, 2022
There was a problem hiding this comment.
The changes look good to me and work well 👍
- confirmed the commands contributed by the plugin work as expected
- confirmed that readonly editors display the
lockdecoration as a caption - confirmed that readonly editors are readonly from a monaco standpoint (with the default message as a user attempts to edit the file)
|
@colin-grant-work Do you want to have a look or can we merge this? |
|
It looks reasonable to me, though I haven't tested it. I'm fine with merging. |
I'm not sure it does. In theia 1.36, I set some files to read only on the file system with chmod, and the resource, filestat, etc. all still say |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Closes #11509
Closes #199
This was more work than initially expected. It seems like we didn't handle readonly editors at all previously (see #199). So this change not only adds the file system permissions extension API, but also enables us to pass permission information all the way to the monaco model and phosphor tabbars.
How to test
Open file from file systemcommands. They should all result in read only editors except for the one that opens themutable-in-mutablefile.Check file system isWritableFileSystemcommand. Input different URI schemes which then displays a notification containing the result of theisWritableFileSystemcall. The extension contributes thereadonlyandmutablefile system schemes, which should returnfalse/truerespectively. Calls tofileshould also returntrue. Everything else should returnundefined, unless contributed by an extension or plugin.Review checklist
Reminder for reviewers